Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package psbt and wif #107

Closed
wants to merge 7 commits into from
Closed

package psbt and wif #107

wants to merge 7 commits into from

Conversation

XuNeal
Copy link
Collaborator

@XuNeal XuNeal commented Jul 19, 2024

Summary of Changes

Motivation and Context

How Has This Been Tested? (Test Plan)

Other information

Screenshots (if appropriate):

Final checklist

  • Did you test both iOS and Android(if applicable)?
  • Is a security review needed(consenlabs/security)?

Security checklist (only for leader check)

  • No backdoor risk
    • Check for unknown network request urls, and script/shell files with unclear purposes,
    • The backend service cannot expose leaked data interfaces for various reasons (even for testing purposes)
  • No network communication protocol risk
    • Check whether to introduce unsafe network calls such as http/ws
  • No import potentially risk 3rd library
    • Check whether 3rd dependent library is import
    • Don't use an unknown third-party library
    • Check the 3rd library sources are fetched from normal sources, such as npm, gomodule, maven, cocoapod, Do not use unknown sources
    • Check github Dependabot alerts, Whether to add new issues
  • Private data not exposed
    • Check whether there are exclusive ApiKey, privatekey and other private information uploaded to git
    • Check if the packaged keystore has been uploaded to git

tyrone98 and others added 7 commits June 20, 2024 18:50
@tyrone98
Feature/bitcoin psbt (#99)
1d52741 
* Add PsbtSigner

* finish taproot sign in psbt

* add auto auto_finalize flag in psbt

* fix invalid schnorr signature

* add sign_psbt into tcx

* get derivation path from bip32_derivations

* fix unit tests in psbt signature

* fix incorrect position auto_finalize in PsbtInput

* rename auto_finalize to autoFinalize in PsbtInput

* ignore auto_finalize
@tyrone98
Revert "Feature/bitcoin psbt (#99)" (#100)
91affa1 
This reverts commit 1d52741.
@tyrone98
Feature/bitcoin psbt (#101)
f32555d 
* Add PsbtSigner

* finish taproot sign in psbt

* add auto auto_finalize flag in psbt

* fix invalid schnorr signature

* add sign_psbt into tcx

* get derivation path from bip32_derivations

* fix unit tests in psbt signature

* fix incorrect position auto_finalize in PsbtInput

* rename auto_finalize to autoFinalize in PsbtInput

* ignore auto_finalize
@xiaoguang1010
chore: remove useless serde-aux library (#103)
b9b7079
@XuNeal
fix: import mnemonic return wrong existed id (#104)
82548af
@XuNeal
feat: allow import test wif in production env (#105)
c223227
@XuNeal @tyrone98
feat: taproot sign script (#98)
74b634b 
* Add PsbtSigner

* finish taproot sign in psbt

* feat: add taproot sign script

fix: rebase issue

fix: append script and control block to witness

* fix: sign tap script no need tweak privatekey

Fix after rebase

* fix: merge missing code

* chore: remove println hash

* add bip322 message signature

* add multi address type in bitcoin psbt

* add tests for bitcoin bip322 sign

---------

Co-authored-by: Sun Feng <[email protected]>
@XuNeal XuNeal marked this pull request as draft July 19, 2024 02:21
@XuNeal XuNeal marked this pull request as ready for review July 19, 2024 03:42
@XuNeal XuNeal closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoguang1010 xiaoguang1010 xiaoguang1010 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuNeal @xiaoguang1010 @tyrone98